Conversation
`make dev` guards on the shared dev database being reachable, so that a missing `make forward-db` tunnel fails with an instruction rather than a bare "connection refused". The guard used `nc -z`, which is not installed by default on every distro — Arch among them. Where it is absent the probe fails for the wrong reason and the target refuses to start with the tunnel up and healthy, which reads as a broken port-forward and sends you debugging kubectl. - `Makefile:56`: open a bash `/dev/tcp` socket instead of shelling out to netcat. No external dependency, and it distinguishes "port closed" from "tool missing" by construction, because there is no tool. The probe is wrapped in an explicit `bash -c` rather than left to make's default `/bin/sh`: `/dev/tcp` is a bash feature, and on Debian-family systems `/bin/sh` is dash, which does not have it. Signed-off-by: Geoff Turk <geoff@ic3.dev>
vthwang
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make devguards on the shared dev database being reachable, so that a missingmake forward-dbtunnel fails with an instruction rather than a bare "connection refused". The guard usednc -z, which is not installed by default on every distro — Arch among them. Where it is absent the probe fails for the wrong reason and the target refuses to start with the tunnel up and healthy, which reads as a broken port-forward and sends you debugging kubectl.Makefile:56: open a bash/dev/tcpsocket instead of shelling out to netcat. No external dependency, and it distinguishes "port closed" from "tool missing" by construction, because there is no tool.The probe is wrapped in an explicit
bash -crather than left to make's default/bin/sh:/dev/tcpis a bash feature, and on Debian-family systems/bin/shis dash, which does not have it.