[patch] adding filters to tekton definitions for mas restore command. - #2549
Open
Sharan-Robinson-IBM wants to merge 2 commits into
Open
[patch] adding filters to tekton definitions for mas restore command.#2549Sharan-Robinson-IBM wants to merge 2 commits into
Sharan-Robinson-IBM wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add facilities-specific archive include toggles to the
download-backup-archiveTekton task and wire them through themas-restorepipeline so facilities archives can be excluded from download the same way Manage archives already can.This change adds two new task parameters:
include_facilities_app_archiveinclude_facilities_db_archiveThese are passed as environment variables (
INCLUDE_FACILITIES_APP_ARCHIVE,INCLUDE_FACILITIES_DB_ARCHIVE) to the underlying Ansible role. The restore pipeline now sets them based on therestore_facilities_appandrestore_facilities_dbpipeline parameters, which are already declared intekton/src/params/backup.yml.j2.Before this change, the two env vars were never set on the task, causing the Ansible role to default them to
trueand always attempt to download the facilities archives — even when a facilities restore was not requested. This change gives the pipeline correct control over which archives are downloaded.Test Results
Before:
After:
The faclities archives are filtered out.