Skip to content

[patch] Add SLS pod template YAML support for LicenseService CR - #2546

Open
AditIBM931 wants to merge 16 commits into
masterfrom
mascore-13292
Open

[patch] Add SLS pod template YAML support for LicenseService CR#2546
AditIBM931 wants to merge 16 commits into
masterfrom
mascore-13292

Conversation

@AditIBM931

Copy link
Copy Markdown
Contributor

Summary

  • add --mas-sls-pod-template-yaml support to mas gitops_suite and mas gitops-suite-license-service
  • propagate SLS pod template content into generated GitOps config
  • update the Tekton SLS GitOps task to pass the new parameter through correctly

Changes

  • CLI updates

    • add help text and argument parsing for --mas-sls-pod-template-yaml in image/cli/mascli/functions/gitops_suite
    • add help text and argument parsing for --mas-sls-pod-template-yaml in image/cli/mascli/functions/gitops_suite_license_service
    • include the configured SLS pod template file in review output for both commands
  • SLS pod template handling

    • read .podTemplates from the provided YAML file
    • write the parsed value into SLS_POD_TEMPLATE in generated config data
    • inject sls_pod_templates into:
      • image/cli/mascli/templates/gitops/appset-configs/cluster/instance/ibm-sls.yaml.j2
      • image/cli/mascli/templates/gitops/appset-configs/cluster/sls/ibm-sls.yaml.j2
  • Tekton wiring

    • changed the env var name in gitops-sls.yml.j2 from POD_TEMPLATE to MAS_SLS_POD_TEMPLATE_YAML
    • append the CLI flag only when the parameter is provided

Related Jira issues

Testing

  • reviewed the branch diff to verify:
    • the new CLI flag is accepted in both suite flows
    • SLS pod template content is written into generated config

@AditIBM931
AditIBM931 requested a review from whitfiea August 19, 2026 15:00
@AditIBM931
AditIBM931 requested a review from a team as a code owner August 19, 2026 15:00
mnivedithaa
mnivedithaa previously approved these changes Aug 20, 2026
@mnivedithaa
mnivedithaa dismissed their stale review August 20, 2026 07:05

tekton tasks and pipeline changes to be added here as well

@mnivedithaa mnivedithaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tekton tasks and pipeline changes to be added here as well

@AditIBM931

Copy link
Copy Markdown
Contributor Author

Follow up: I added the Tekton parameter mas_sls_pod_template_yaml.

@mnivedithaa mnivedithaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updates to SLS pipeline is missing

- name: mas_pod_template_yaml
value: $(params.mas_pod_template_yaml)
- name: mas_sls_pod_template_yaml
value: $(params.mas_slscfg_pod_template_yaml)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be referring to sls pod template instead of sls cfg pod template right? Also params is not defined

- name: POD_TEMPLATE
- name: MAS_SLS_POD_TEMPLATE_YAML
value: $(params.mas_slscfg_pod_template_yaml)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. sls pod template param is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants