[patch] Add SLS pod template YAML support for LicenseService CR - #2546
Open
AditIBM931 wants to merge 16 commits into
Open
[patch] Add SLS pod template YAML support for LicenseService CR#2546AditIBM931 wants to merge 16 commits into
AditIBM931 wants to merge 16 commits into
Conversation
added 12 commits
July 21, 2026 21:37
mnivedithaa
previously approved these changes
Aug 20, 2026
mnivedithaa
dismissed
their stale review
August 20, 2026 07:05
tekton tasks and pipeline changes to be added here as well
mnivedithaa
reviewed
Aug 20, 2026
mnivedithaa
left a comment
Contributor
There was a problem hiding this comment.
tekton tasks and pipeline changes to be added here as well
Contributor
Author
|
Follow up: I added the Tekton parameter |
mnivedithaa
reviewed
Aug 20, 2026
mnivedithaa
left a comment
Contributor
There was a problem hiding this comment.
Also updates to SLS pipeline is missing
| - name: mas_pod_template_yaml | ||
| value: $(params.mas_pod_template_yaml) | ||
| - name: mas_sls_pod_template_yaml | ||
| value: $(params.mas_slscfg_pod_template_yaml) |
Contributor
There was a problem hiding this comment.
This should be referring to sls pod template instead of sls cfg pod template right? Also params is not defined
| - name: POD_TEMPLATE | ||
| - name: MAS_SLS_POD_TEMPLATE_YAML | ||
| value: $(params.mas_slscfg_pod_template_yaml) | ||
|
|
Contributor
There was a problem hiding this comment.
same here. sls pod template param is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mas-sls-pod-template-yamlsupport tomas gitops_suiteandmas gitops-suite-license-serviceChanges
CLI updates
--mas-sls-pod-template-yamlinimage/cli/mascli/functions/gitops_suite--mas-sls-pod-template-yamlinimage/cli/mascli/functions/gitops_suite_license_serviceSLS pod template handling
.podTemplatesfrom the provided YAML fileSLS_POD_TEMPLATEin generated config datasls_pod_templatesinto:image/cli/mascli/templates/gitops/appset-configs/cluster/instance/ibm-sls.yaml.j2image/cli/mascli/templates/gitops/appset-configs/cluster/sls/ibm-sls.yaml.j2Tekton wiring
gitops-sls.yml.j2fromPOD_TEMPLATEtoMAS_SLS_POD_TEMPLATE_YAMLRelated Jira issues
Testing