IBX-12207: Used design system dark input mode in the header search - #2019
Merged
tischsoic merged 1 commit intoAug 20, 2026
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Contributor
Author
|
Folding this into #2015 at the author's request — the header work reviews better as one story, and the commit is already contained in that branch (fast-forwarded, same sha Consequence recorded in #2015: it now carries the design-system dependency, so its merge order is design-system#126 → design-system#131 → #2015. Closing; branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
IBX-12207-update-header-styling; only the top commit belongs to this PR.Description:
Switches the header search to the design system's new dark input variant instead of its own hand-rolled dark skin: the wrapper sets
--ids-mode: dark, the autocomplete panel re-asserts--ids-mode: light(it is a white surface inside the dark scope), and ~40 lines of duplicated colour rules are deleted. Only the header's purple accent and the field's size stay local.Merge order: design-system#126 (dark-mode mechanism) → ibexa/design-system#131 (dark input variants) → this PR. Merging earlier renders the search with light input styling on the dark header.
Note for reviewers: the accent override sits on
.ids-input-text .ids-inputrather than the wrapper, because the DS dark variant re-points those custom properties on the input element itself, where an inherited ancestor value cannot win.For QA:
Global search on the dashboard — default, hover, focus, typed, and clear states should look exactly as before this PR (that is the point: same visuals, DS-owned). Autocomplete panel must stay light with correctly styled buttons inside.
Documentation: