_FQexecClearSQLDA: clear the actually provided sqlda - not result->sqlda_out

[HuBandiT]

No description provided.

[mkgrgis]

@HuBandiT , what about testing results or test cases?

[HuBandiT]

@HuBandiT , what about testing results or test cases?

Greetings,

Apologies.

I am not sure how to approach that. I do not see a test suite in this source code, and I am not knowledgeable enough to add one.

Most of what I am trying to do is understanding the code by refactoring without changing behaviour, working my way towards solving ibarwick/firebird_fdw#50 .

With the occasional minor "oh, but surely this can't be right" type bugfixes sneaking in.

Do you guys have a suggestion?

Do not consider this as an actual pull request for now... I started with an actual bug fix, yes... but then quickly descended into a frenzy of refactoring.

[mkgrgis]

@HuBandiT , libfq has no separate tests, but you can ensure this Firebird FDW TAP perl tests are ok and add some testcases to Firebird FDW.

[HuBandiT]

@HuBandiT , libfq has no separate tests, but you can ensure this Firebird FDW TAP perl tests are ok and add some testcases to Firebird FDW.

Oh, nice, thank you!

I haven't deeply looked into firebird_fdw yet.

But soon I will, and then I will look into them and check my work by running those tests.

New test cases: I am not sure what new test cases to add, since my changes will be performance-related and "non-functional" – in the sense that they do not change what result a (firebird_fdw-based) PostgreSQL query returns, only how fast it returns it, and how big a result it can return (before running into memory limits) at all.

[mkgrgis]

@HuBandiT , really performance tests isn't obligatory or traditional for FDW repos. In this case you should only insure all Firebird FDW tests are still ok after your changes.