fix(ci): install jq in the container so the Trope IR test actually runs - #32
Merged
Conversation
`CI / required` failed at "Validate repository contracts" with exit code 2 and
a single line of output:
jq is required
That comes from tests/check-examples.sh:15, which exits 2 when jq is absent.
The pinned idris2-pack image does not ship it, so the Trope IR conformance
test — the one that asserts every example lowers to valid Trope IR — has never
actually executed in CI. It bailed before testing anything.
This is the same class of problem as the missing xz fixed in #28, so the step
now handles both: it collects what is missing, installs in one apt-get pass,
and prints both versions so the log records what was used. Already-provisioned
images skip the install entirely.
Verified against origin/main (d29f89e) in a local checkout: all four contract
scripts exit 0, and `bash -n` parses every .sh under tests/ and scripts/.
tests/check-examples.sh ................. exit 0 (examples lower to valid Trope IR)
tests/aspect_tests.sh ................... exit 0 (PASS=3 FAIL=0 WARN=0)
scripts/check-root-shape.sh ............. exit 0 (45 entries, 46 permitted)
tests/workflows/validate_workflows_test.sh exit 0
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CI / requiredis the last red check onmain. After #31 fixed the versionassert, the job got two steps further and now fails at Validate repository
contracts with exit code 2 and one line of output:
Root cause
tests/check-examples.sh:15:The pinned
idris2-packimage does not shipjq. So the Trope IR conformancetest — the one asserting every example lowers to valid Trope IR — has never
actually executed in CI. It bailed before testing anything.
That makes this more than a build fix: it turns a step that always died early
into one that genuinely exercises the language's core guarantee.
Fix
Same class of problem as the missing
xzin #28, so the step now handles both:collect what is absent, install in a single
apt-getpass, print both versionsso the log records what ran. A no-op on images that already have them.
Verified locally against
origin/main(d29f89e)Note
check-examples.shskips the verdict round-trip when no siblingtropecheckbinary is built — that part still needstrope-checker, and isreported as a
note, not a pass.🤖 Generated with Claude Code