Skip to content

fix(ci): build Dory FFI before xcodebuild#81

Open
patrickleet wants to merge 1 commit into
feat/cluster-backend-abstractionfrom
fix/dory-ffi-build
Open

fix(ci): build Dory FFI before xcodebuild#81
patrickleet wants to merge 1 commit into
feat/cluster-backend-abstractionfrom
fix/dory-ffi-build

Conversation

@patrickleet

Copy link
Copy Markdown
Collaborator

Summary

  • install the Rust and protobuf prerequisites used by Dory's clean-checkout build
  • generate and verify DoryFFI.xcframework plus the UniFFI Swift binding before SwiftPM resolution
  • keep the deterministic Xcode DerivedData app build and add structural regression coverage

Test output

  • cargo test --test dory_smoke_workflow --test colima_smoke_workflow (7 passed)
  • clean Dory checkout reproduced the protoc requirement in the upstream FFI generator

Tracks [[tasks/hops-cli-dory-macos-smoke]].
Targets PR #70 so the opt-in test-dory workflow exercises this fix.

Dory's rebased upstream requires a generated Rust UniFFI XCFramework before SwiftPM can resolve the app package. Install rust/protobuf, materialize and verify the ignored artifacts, then build the app.\n\nImplements [[tasks/hops-cli-dory-macos-smoke]]
@patrickleet patrickleet added the test-dory Run the opt-in macOS Dory smoke test label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: de8d44c0-c1b1-40de-97de-7ce24ddcac8c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dory-ffi-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-dory Run the opt-in macOS Dory smoke test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant