feat(graphql): pre-release surface IR + command pipeline + projection return#129
Open
patrickleet wants to merge 8 commits into
Open
feat(graphql): pre-release surface IR + command pipeline + projection return#129patrickleet wants to merge 8 commits into
patrickleet wants to merge 8 commits into
Conversation
…helpers Implement pre-release tracks for graphql-qs-prerelease-1: - Surface IR (build_surface / surface_for_role); SDL emits via IR - Browser QueryCache + command pipeline (ack/fact/projection, rollback) - projection_return helpers + skill docs for same-tx vs async projectors Product rule: command success ≠ projection visibility; default ack/fact + reconcile. Residuals (full schema-from-IR, e2e-ui route migrate, extract packages, client_reconcile manifest) remain in GitKB v1/state.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pages use gql.commands.* with optimistic → fact/ack → reconcile (refetch/sub). List UI is cache-driven; hand-rolled mergeFromServer/pending maps removed. bindCommandsPipeline wires generated COMMAND_DOCS through runCommandPipeline. Tests assert page structure and pipeline behavior (rollback, refetch).
Pages no longer seed/subscribe/sync QueryCache by hand. Document stores auto-seed from SSR, follow cache notifications, and (live) open subscriptions. UI reads \$store.data / \$store.status; commands still attach optimistic targets via store.target().
- Rename command UI helpers to fx so they never shadow \$effect - Type layout/Auth children as Snippet; use \$app/state consistently - Convert +error onMount → \$effect (browser-guarded) - Fix chat PageData (drop invalid userId); allowImportingTsExtensions - Clear empty CSS ruleset; CommandClient cast for pipeline binder svelte-check: 0 errors / 0 warnings
Navbar CTA is Create account (/signup); Auth keeps Sign in (/signin). Signup starts the same OIDC flow as sign-in so Zitadel can register when enabled.
…make up Auth.js error=Configuration was opaque: OIDC issuer unreachable (Docker/Zitadel not running). Probe IdP before starting OIDC and return 503 with make up steps. Bootstrap login policy sets allowRegister for Create account on hosted login.
Async projectors: keep optimistic list state; reconcile: none on todos/admin. Soft catch-up refetch later; writeServerDataPreservingPending if server still lags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a vertical slice of [[tasks/graphql-qs-prerelease-1]] for merge into
tasks--graphql-qs-epic(not main).src/graphql/surface.rs):build_surface,surface_for_role/RoleGrant, dialect-honest comparison ops;graphql_sdl_*builds SDL only via IR.tests/e2e-ui/ui/src/lib/gql/cache/): document-keyedQueryCache,CacheOp/Effect,runCommandPipeline(optimistic → network → result.kind → effects → reconcile). Unit tests prove ack does not invent full list rows, rollback on error, projection field apply.projection_return.rs) + skill docs: same-tx view JSON vs async ack/fact.Residuals (honest; tracked in GitKB
specs/query-layer/v1/state)client_reconcileonexposed_command→ gen-commandsTest plan
cargo test --lib surfacecargo test --lib projection_returncargo test --test graphql_sdlnode --experimental-strip-types tests/e2e-ui/ui/tests/run-pipeline-unit.mjs