Skip to content

docs: pre-release surface IR + client cache design (stack onto GraphQL epic)#128

Closed
patrickleet wants to merge 4 commits into
tasks--graphql-qs-epicfrom
feat/surface-ir-and-client-cache
Closed

docs: pre-release surface IR + client cache design (stack onto GraphQL epic)#128
patrickleet wants to merge 4 commits into
tasks--graphql-qs-epicfrom
feat/surface-ir-and-client-cache

Conversation

@patrickleet

Copy link
Copy Markdown
Collaborator

Summary

Design branch for pre-release rewrites stacked on the GraphQL query-layer epic.

  • Surface IR becomes required for first ship (single source for SDL + runtime).
  • Browser-only optimistic client cache + command apply API (not server table mutations).
  • Normative specs + terraform-style gaps in GitKB: specs/query-layer/v1/*.
  • Handoff epics: graphql-qs-surface-ir-1, graphql-qs-client-cache-1, umbrella graphql-qs-prerelease-1.

Base / target

Implementation

Full implementation is not in this PR (docs pointer only). Agents execute the epics against the GitKB specs/state.

Test plan

  • Specs/state/epics in GitKB (separate commit)
  • Surface IR implementation (epic children)
  • Client cache implementation (epic children)

Replace select()/role()/filter()/allow_aggregations with
read()/grant()/rows()/aggregations so deny-by-default auth reads as
grant + columns + rows. Pre-ship API cleanup on the GraphQL epic branch.
…or codes

Add multi-tenant subscription isolation e2e, m2m relationship client-where
e2e, and freeze ENGINE_ERROR_CODES with unit coverage. Scaffold comment
aligns grant/read/rows vocabulary. Completes graphql-qs-gap-1 evidence WPs.
Align resolve_command with frozen v1 codes (422→REJECTED, no CONFLICT),
set extensions.status on command failures, and use client_error for
empty-role FORBIDDEN. Honest e2e covers empty-role + command status map.
Branch feat/surface-ir-and-client-cache stacks on the GraphQL epic.
Normative specs live in GitKB (v1/surface-ir, v1/client-cache, v1/state).
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a6c3d4a5-66ae-413e-a5ef-7e37bd447721

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/surface-ir-and-client-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Closing: docs pointer not needed; design lives in GitKB. Epic work continues on tasks--graphql-qs-epic.

@patrickleet
patrickleet deleted the feat/surface-ir-and-client-cache branch July 16, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant