docs(rules): file a Problem only when work is actually blocked - #137
Conversation
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe Problem-writing guidance now separates user or business barriers from routine work. It adds validation criteria, a routine-work example, and acceptance criteria that require a genuine goal-blocking barrier. ChangesProblem-writing guidance
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/rules/DEV-160.md`:
- Line 40: Update the sentence in DEV-160 to use grammatical wording: replace
the “Filing routine acts as Problems…” phrasing with “Filing routine work as
Problems splits the work into micro-chunks.”
- Around line 12-14: Update the explanatory paragraph in DEV-160 by replacing
the claim that “no one can tell when it is resolved” with a precise statement
that “pinned post needs upgrade” fails to identify the user or business outcome
being blocked. Keep the existing examples and prioritization concerns unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 37127a13-5bb3-4fb3-b171-fe248e77f66b
📒 Files selected for processing (1)
docs/rules/DEV-160.md
|
@holdex pr add-time 15m |
DEV-160 tells you how to write a Problem statement but never says what does not deserve to be one. So routine work gets filed as Problems, and each one adds an issue to track, a notification on every PR that touches it, and a status nobody updates, while tracking nothing that was ever blocked.
This adds the qualification test to DEV-160 rather than opening a new rule. A clear Problem statement already implies the thing is worth stating as a Problem: if you cannot name an inability, there is nothing to file. Same claim, checkable pass or fail on one subject, so DEV-010's split test does not apply.
What changes:
Problem: pinned post needs upgrade, alongside the existing technicality and no-actor cases.The Problem statement was trimmed to stay inside DEV-050's 250-character cap, which the rules audit enforces on push.
This came out of a cleanup in holdex/marketing, where one Goal had 23 open sub-issues and 12 of them were routine acts. Three separate open issues asked for the same pinned post to be swapped; one had its Solution checkbox already ticked and had been open since March 2025.
Summary by CodeRabbit