Initialize gettext translation function and resolve formatting failures - #90
Merged
zstanecic merged 4 commits intoSep 6, 2026
Merged
Conversation
Co-authored-by: zstanecic <11149715+zstanecic@users.noreply.github.com>
Co-authored-by: zstanecic <11149715+zstanecic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing translation function initialization and formatting issues
Initialize gettext translation function and resolve formatting failures
Sep 6, 2026
Collaborator
|
@copilot checks failed. see why these failed and fix. |
…right config Co-authored-by: zstanecic <11149715+zstanecic@users.noreply.github.com>
Contributor
Author
The CI failure in the Pyright pre-commit check was caused by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several modules were invoking the gettext translation function
_()without initializing the translation engine or providing type annotations, triggering PyrightreportUndefinedVariableandreportUnboundVariableerrors. Additionally, pre-commit formatting checks failed due to missing trailing commas and unformatted code.Changes
Translation Initialization & Type Annotations
addonHandler.initTranslation()and_: Callable[[str], str]type declarations to modules utilizing_(), specificallyskipTranslation.pyandinstallTasks.py.stubPath = ".vscode/typings"topyproject.tomlunder[tool.pyright]so CLI type checking recognizes built-in NVDA translation stubs from.vscode/typings/__builtins__.pyi.Code Formatting & Pre-commit Compliance
add-trailing-commaandruff formatacross the codebase (clockHandler.py,sconstruct, andsite_scons).