SASL PLAIN and anonymous authentication#130
Conversation
I'm sure this can be done better but for now I want the PR to pass
|
I'll leave fixing that build error to @dolanske because reproducing it locally is blocked by other errors on my system. |
zealsprince
left a comment
There was a problem hiding this comment.
Overall I like where this landed. The typed OrbitError is a real improvement over stringly errors at the boundary, and the .context() pass means failures will actually be traceable now. Left inline comments, the two I'd want sorted before merge are the split_at panic and the question of waiting for the AUTHENTICATE challenge. The silent fallback I'd at least want a shared understanding on. The UI surfacing can be a follow-up issue.
A few things that didn't fit inline:
- The lockfile looks half-updated: catalog says vite-plus ^0.2.4 but the catalogs section resolves 0.2.1, root gets 0.2.4, and the apps stay on 0.2.1. Does a fresh
pnpm installsettle it for you? - The
@ts-ignores on defineConfig, is that a vite-plus 0.2.4 type regression? If so I'd swap to@ts-expect-errorwith the upstream issue linked so they self-report when fixed. - The wasm-pack block is copy-pasted between ci.yml and cd.yml and runs cold each time. Composite action plus caching once the sourcing questions are answered?
Curious about the nightly requirement too, is that just for the if-let match guards or is more coming that needs it?
Also, we should look to resolve the CI errors with @dolanske so that we can get a nice clean PR out there :)
f6a7493 to
7f0e46f
Compare
7f0e46f to
de7df8a
Compare
That printed this, but didn't actually change anything:
I don't know what's causing it, I actually updated vite-plus in the hopes of fixing that issue. @dolanske suggested to ignore the problem for now so maybe he can try to look into it once he is available.
Sounds good but I don't want to implement that in this PR.
There is no nighly requirement, I have removed it. :) |
| use core_shared::actor::{ActorCommand, ActorMessage, IrcActor}; | ||
| use futures::channel::oneshot; | ||
|
|
||
| const LONG_PASSWORD: &str = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; |
zealsprince
left a comment
There was a problem hiding this comment.
Good with your feedback! I'll capture the caching concern for the packages as a separate ticket!
This PR fixes the following divergences between the prototype branch and #31:
OrbitErrortype which is used to returnThe other requirements of SASL PLAIN and ANONYMOUS authentication #31 have already been implemented on the prototype branch but this PR should be used to review any code relevant to SASL PLAIN and ANONYMOUS authentication #31.
Additions after review:
ServerMetadatafrom ISUPPORTResolves: #31