Dev3.0.34 Snapshot of detach & presenterTool PR - #279
Open
hiroshisuga wants to merge 196 commits into
Open
Conversation
Even when a sharescreen etc starts, the popup keeps the presentation container.
Finally it's fixed. Does this make other problems?
Seems to make no difference...
And add the comments on what is affected by these changes.
update 3.0.13
bump to 3.0.14
The style changing panel is now working properly.
Revert the previous change and use isMobile from utils/deviceinfo
import isMobile from utils/deviceinfo. This 'isMobile' includes both phones and tablets, whereas the 'Mobile' from layout/enums.js does not include tablets as it is only for the layout.
suggested by coderabbit.
chore: BigBlueButton 3.0.33 iteration
…bluebutton#25571) * docs: iteration doc sync for 3.0.33 (bigbluebutton#25568) * docs: iteration doc sync for 3.0.33 Covers documentation-worthy changes on v3.0.x-release since the v3.0.32 tag that were not yet reflected in the docs: - new-features.md: Panopto external video player; the new public.whiteboard.slideSwapDecodeTimeoutMs client setting; corrected the html5PluginSdkVersion line to 0.0.104; tagged maxSharedNotesInitialContentUrlPayloadSize with 3.0.33 and added numPresentationDownloadThreads to the bbb-web properties ledger. - create.tsx: "(added 3.0.33)" on sharedNotesInitialContentMarkdown and sharedNotesInitialContentMarkdownUrl. - api.md: the three shared-notes initial-content create parameters added to the "Updated in 3.0" list, tagged with the point release that shipped them. - plugins.md: useTimer hook (plugin SDK 0.0.104) and the new senderRole field on useLoadedChatMessages. - faq.md: external video line now mentions Panopto.
1. Do not access the notes when not detached 2. Put an excuse for 404 error occurs when detached but no notes loaded
Although no change is visible, this still makes the logic clearer.
BBB uses the darkreader framework instead of tldraw's darkmode. We need to copy the CSS rules manually.
hiroshisuga
changed the title
🚨 Automated tests failed |
hiroshisuga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a snapshot of this PR for future information.
Now I am diving into a new PR which aims to remove all the global constructor injection to get tldraw work.
So this PR still works without all the modification that would be done in tldraw fork of BBB, but can be outdated depending on how the new PR is developed.
Will resolve bigbluebutton#18182, bigbluebutton#11403
Problems remained
dark mode does not work (show normal mode) -> darkReader is implemented as a browser function, so it would not work on the popup window (needs confirmation)-> now it works by copying CSS rules (Aug 2026)depending on browser and OS, fullscreen in the same monitor does not expand the presentation (if you move to another monitor, it works). If it happens, you click the screen then tldraw realizes and the screen size has changed (but not always...).the above problem is solved. Now zooming (by wheel or by clicking the zoom button) is the only problem remained. -> accidentally fixed(?) by 5726c9e, after the evaporation of cache???-> solved by replacing requestAnimationFrame and cancelAnimationFrame with those of popup (cc3d507).resize by dragging the resize handles does not work (focus is lost); dom.ts in tldraw causes the problemstyle panel including the color picker does not work well. When mouse-down, the mouse-up event is not caught, behaving as if mouse is kept down when hovered over the button, picking up every color that mouse hover. The reason is in this file: tldraw-alpha30/packages/tldraw/src/lib/ui/components/primitives/ButtonPicker.tsxFonts are not properly loaded on the popup, e. g., the var(--tl-font-draw) font which is the default on latin languages.Frequent 3006 error from graphql since 3.0.13 or 14 (not happening on 3.0.11)Firefox suffers an error of too much recursion of font measurement when the text font is changed more than twice (or once?). The tldraw files packages/editor/src/lib/editor/managers/TextManager.ts, packages/tldraw/src/lib/shapes/text/TextShapeUtil.tsx, and packages/editor/src/lib/utils/WeakMapCache.ts may account for it.-> fixed by 3113f60Additional features
on the popup, the hand icon turns red, being more visible in the screen of the real lecture.-> replaced by the laser pointer PRadd Kosugi-Maru font to look a text funnier for the Japanese locale-> Dev3.0.15 use better font #235 (only for popup)however, whiteboard drawings are not reflected.ToDo
if the frequent 3006 error disappears. -> still appears on 3.0.15 ->not observed anymore on 3.0.22, so reverted this PR (26.3.11).On mobile devices (especially iPad) it is unstable. Disabling this feature is an optionDisabled for mobile devices (only for desktop devices)whiteboard annotations do not show up on the current slide window.Caution
Tldraw2.0 internally (and implicitly) uses global variables/functions, making some conflicts with popup, including:
You need to modify /usr/share/bigbluebutton/nginx/web manually, and copy script/extract_pptx_notes.py to /usr/local/bin/ manually (latter only once; is there a better location?).
Screenshot:
(sample slide from https://powerpoint.cloud.microsoft/create/en/presentation-templates/)
slide_sample.pptx