Dev3 laser keepupdating - #244
Open
hiroshisuga wants to merge 90 commits into
Open
Conversation
To adopt this PR to popup again, you need: - to change -> "const targetDoc = popupWindow?.document || document;" (at two places whare "const targetDoc = document"; is writted) - to add-> "popupWindow" at the ends of two React.useEffect()s which defines "const targetDoc" (same functions above)
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports (to view the report locally, see the docs) |
This might have added some stability in the code. But almost surely unnecessary (always included in the args above).
according to the coderabbitai
according to coderabbitai
Remove <svg class="tl-collaborator__cursor-hint"> that appears typically when the cursor moves near the right or the bottom edge of the viewer's screen. We do not need it when the laser is shown.
🚨 Automated tests failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Laser pointer implementation]
Motivation
but no laser (actually any other cursors) shown as a presenter although laser visible in the viewer's screen(Aug 2026)
To do and problems
Not working for a presenter on iOS (as a viewer there is no problem)akka-apps does not start properly (killed gracefully).bbb-conf --restart sometimes does not work for that reason. -> this is not the problem of the source code. By apt install --reinstall bbb-apps-akka can recover the problem (or simply, sudo systemctl start bbb-apps-akka) : the point is to execute: ln -s /lib/systemd/system/bbb-apps-akka.service /etc/systemd/system/multi-user.target.wants/bbb-apps-akka.service , and ln -s /lib/systemd/system/bbb-apps-akka.service /etc/systemd/system/bigbluebutton.target.wants/bbb-apps-akka.service , which are not included in the deploy.sh in akka-bbb-apps source code. -> fix(akka-apps): [development] Correctly start bbb-apps-akka by creating symlinks bigbluebutton/bigbluebutton#25372 fixed the problemTo use this PR with the popup PR, you need:
"const targetDoc = popupWindow?.document || document;"(at many places where "const targetDoc = document"; is used) "const targetDoc = getWhiteboardDocument();"to add-> "popupWindow" at the ends of two React.useEffect()s which defines "const targetDoc" (same functions above)(when refactoring on Apr 26, it turned out that they need not to be changed)