Dev3 popup + presenter tool keepupdating - #240
Open
hiroshisuga wants to merge 254 commits into
Open
Conversation
Even when a sharescreen etc starts, the popup keeps the presentation container.
Finally it's fixed. Does this make other problems?
Seems to make no difference...
And add the comments on what is affected by these changes.
update 3.0.13
bump to 3.0.14
The style changing panel is now working properly.
Dev3.0.14 suppress notification
….jsx ideally this should be done for other places.
…ayout-manager/layoutEngine.jsx
…ayout-manager/customLayout.jsx
…ayout-manager/customLayout.jsx Fix the condition
…ayout-manager/ayoutEngine.jsx fix the condition
…ayout-manager/videoFocusLayout.jsx
…ayout-manager/participantsAndChatOnlyLayout.jsx
…ayout-manager/presentationFocusLayout.jsx
…ayout-manager/presentationOnlyLayout.jsx
…ayout-manager/smartLayout.jsx
…ayout-manager/unifiedLayout.jsx
…ayout-manager/mediaOnlyLayout.jsx
…nent.jsx Resolved by already merged PR: bigbluebutton/tldraw#36 which is ported by: bigbluebutton#23957
…ntation/component.jsx
Shows notes only to the moderator or to the assigned presenters.
usually these do not happen, but not impossible if a user generates a fake URL.
🚨 Automated tests failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve bigbluebutton#18182, bigbluebutton#11403
Problems remained
dark mode does not work (show normal mode) -> darkReader is implemented as a browser function, so it would not work on the popup window (needs confirmation)-> now it works by copying CSS rules (Aug 2026)tooltip not shown-> now they are shown!depending on browser and OS, fullscreen in the same monitor does not expand the presentation (if you move to another monitor, it works). If it happens, you click the screen then tldraw realizes and the screen size has changed (but not always...).the above problem is solved. Now zooming (by wheel or by clicking the zoom button) is the only problem remained. -> accidentally fixed(?) by 5726c9e, after the evaporation of cache???-> solved by replacing requestAnimationFrame and cancelAnimationFrame with those of popup (cc3d507).resize by dragging the resize handles does not work (focus is lost); dom.ts in tldraw causes the problemthe global variable HTMLElement is injected with that of popupWindow, fixing the problem above, yet other problems to be expected. -> indeed. We now back up the window.HTMLElement at utils/HTMLElementBackup and use the original value at for instance the chat message scroll (Fix: chat scrolls even with popped up presentation #232).style panel including the color picker does not work well. When mouse-down, the mouse-up event is not caught, behaving as if mouse is kept down when hovered over the button, picking up every color that mouse hover. The reason is in this file: tldraw-alpha30/packages/tldraw/src/lib/ui/components/primitives/ButtonPicker.tsxFonts are not properly loaded on the popup, e. g., the var(--tl-font-draw) font which is the default on latin languages.Frequent 3006 error from graphql since 3.0.13 or 14 (not happening on 3.0.11)Firefox suffers an error of too much recursion of font measurement when the text font is changed more than twice (or once?). The tldraw files packages/editor/src/lib/editor/managers/TextManager.ts, packages/tldraw/src/lib/shapes/text/TextShapeUtil.tsx, and packages/editor/src/lib/utils/WeakMapCache.ts may account for it.-> fixed by 3113f60slide zoom is not inherited to the popup (perhaps currentPresentationPageRef is initialised in whiteboard/component.jsx: see #23828-> fixed by Improve cross-realm portability of editor animation frames bigbluebutton/tldraw#55 .Additional features
on the popup, the hand icon turns red, being more visible in the screen of the real lecture.-> replaced by the laser pointer PRadd Kosugi-Maru font to look a text funnier for the Japanese locale-> Dev3.0.15 use better font #235 (only for popup)however, whiteboard drawings are not reflected.ToDo
if the frequent 3006 error disappears. -> still appears on 3.0.15 ->not observed anymore on 3.0.22, so reverted this PR (26.3.11).On mobile devices (especially iPad) it is unstable. Disabling this feature is an optionDisabled for mobile devices (only for desktop devices)whiteboard annotations do not show up on the current slide window.Caution
Tldraw2.0 internally (and implicitly) uses global variables/functions, making some conflicts with popup, including:window.cancelAnimationFrame-> described and resolved in the issue [Whiteboard] Improve cross-realm compatibility in the bundled tldraw fork bigbluebutton/bigbluebutton#25597
You need to modify /usr/share/bigbluebutton/nginx/web manually, and copy script/extract_pptx_notes.py to /usr/local/bin/ manually (latter only once; is there a better location?).
Now this PR assumes using a custom tldraw package, with bigbluebutton/tldraw#54 and bigbluebutton/tldraw#53 incorporated.
Now fullscreen is much more simplified, without using the popupWindow variable. However, a problem remains (and it also happens partially in the original BBB code):
On Windows, maximizing the popup window with the OS window controls is clearly distinguishable from entering fullscreen mode. Also, once the popup enters fullscreen mode, the OS maximize/restore button is no longer visible.
On macOS, however, the OS window control remains visible even after entering fullscreen mode. This can be confusing, because users may try to use the OS restore button to exit fullscreen. In reality, OS window maximization and the browser Fullscreen API are separate states, so ideally the OS control should still represent only the window maximized state and should not appear to act as a fullscreen exit control.
At the moment, there does not seem to be a clean and portable way for a web application to control or hide this OS-level window control. For now, this should be treated as a platform-specific limitation of the popup fullscreen behavior.
ウィンドウズだと、OSの最大化ボタンでの最大化は、BBBのフルスクリーン化と明確に区別できる上に、フルスクリーン化後は、OSの最大化解除ボタンが見えなくなっています。特に最後の点が重要で、MacOSではそれが見えてしまうために、ユーザーがOSの最大化解除でフルスクリーンから脱出しようとしてしまい、混乱がおきます。実は本来、(OSの最大化とフルスクリーンを区別するならば)フルスクリーン化後のOSのボタンは、最大化ボタンのままであるべきです。
Screenshot:

(sample slide from https://powerpoint.cloud.microsoft/create/en/presentation-templates/)
slide_sample.pptx