fix(scan): count packages with unknownReason metadata as UNKNOWN#606
Merged
Conversation
v3nant
marked this pull request as ready for review
July 16, 2026 17:57
facundo-herodevs
approved these changes
Jul 16, 2026
sunshastry
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadatashape: unknown/unresolvable packages now arrive as{ unknownReason }instead ofnull.eol_unknown_countanalytics metric.Changes
@herodevs/eol-sharedfromv0.1.20tov0.1.23, which teachesderiveComponentStatusto treat{ unknownReason }metadata asUNKNOWNand models theComponentMetadataunion (EolScanComponentMetadata | UnknownComponentMetadata).package-lock.jsonto the resolvedv0.1.23commit.metadata: nullshape to{ unknownReason }indisplay.svc.test.tsandfile.svc.test.ts.unknownReasoncount asUNKNOWNand notOK.Testing
npm run typecheck— passesnpm run lint— passesnpm run test— 248 passed (24 files)Screenshots
n/a
Risks & Rollback
@herodevs/eol-sharedbump; the sole CLI consumer (countComponentsByStatus) delegates to the library and is otherwise unchanged.metadatais an opaque JSON scalar, so no query changes.@herodevs/eol-sharedpin tov0.1.20and the accompanyingpackage-lock.jsonchange.Checklist