feat(squads): SquadPolicy — captain/sub-captain or super-admin authorization - #453
Open
Re-Gouveia-QA wants to merge 2 commits into
Open
feat(squads): SquadPolicy — captain/sub-captain or super-admin authorization#453Re-Gouveia-QA wants to merge 2 commits into
Re-Gouveia-QA wants to merge 2 commits into
Conversation
…ization Materializes the Policies/SquadPolicy design already noted in CONTEXT.md: canManage() authorizes super-admins unconditionally, otherwise only an active Captain/SubCaptain of the target squad; authorize() throws AuthorizationException, matching the throw_unless pattern already used in CreateSquad/ManageSquadStatus.
4 tasks
guisaliba
approved these changes
Jul 27, 2026
|
LGTM! |
Danilo-Sam
approved these changes
Jul 27, 2026
danielhe4rt
reviewed
Jul 28, 2026
danielhe4rt
left a comment
danielhe4rt
left a comment
Contributor
There was a problem hiding this comment.
As Policies por padrão são vinculadas diretamente à model referida, mas não foi o caso da PR atual.
Isso é por design ou alguma outra tarefa faz isso?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materializa o design de
Policies/SquadPolicyjá descrito em CONTEXT.md.canManage(User $actor, Squad $squad): bool— verdadeiro para super-admins incondicionalmente; caso contrário, apenas para um Captain/SubCaptain ativo do squad alvo.authorize(User $actor, Squad $squad): void— lançaAuthorizationException, seguindo o padrãothrow_unlessjá utilizado emCreateSquad/ManageSquadStatus.Fora do escopo (conforme o plano): ações concretas que irão consumir esta policy (PromoteToSubCaptain, DecideApplication, MarkExMember, AssignCaptain, ReallocateLeader) — ainda não implementadas neste módulo.
Plano de testes
SquadPolicyTest.php— 5 cenários (captain do próprio/outro squad, super-admin, sub-captain, membro comum), 5/5 verdesapp-modules/squads— 27/27 verdesCloses #357