Skip to content

Add RULES for break on single character - #707

Merged
Bodigrim merged 1 commit into
masterfrom
rules-break
Aug 12, 2026
Merged

Add RULES for break on single character#707
Bodigrim merged 1 commit into
masterfrom
rules-break

Conversation

@Lysxia

@Lysxia Lysxia commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Close #695

We have to use singleton because breakOn expects a Text as the needle. Nevertheless, I checked that the rule does apply and observed a speedup in some very artificial micro-benchmarks for both the strict and lazy variant.

@Bodigrim

Copy link
Copy Markdown
Contributor

Thanks! Do we want the same for takeWhile / dropWhile?

@Lysxia

Lysxia commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Sure thing. I somehow missed that we could do it with break (even though it's in your issue!).

@Bodigrim
Bodigrim merged commit 84a6972 into master Aug 12, 2026
48 checks passed
@Bodigrim
Bodigrim deleted the rules-break branch August 12, 2026 21:28
@Bodigrim

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RULE from break to breakOn

2 participants