feat: [IAC-7521]: use UI log viewer for workspace execution instead of text logs#44
Open
rahulbalani-eng wants to merge 3 commits into
Open
feat: [IAC-7521]: use UI log viewer for workspace execution instead of text logs#44rahulbalani-eng wants to merge 3 commits into
rahulbalani-eng wants to merge 3 commits into
Conversation
Changes: - Modified execute workspace command to launch interactive UI log viewer - Replaced logstream.FollowMulti with pipeline.RunLogViewer in modules/iacm/plan.go - Changed import from logstream to pipeline module Known Issue: When the UI viewer launches, the left panel works correctly - it shows the step hierarchy, updates in real-time, and navigation works. However, the right panel does not display log content properly. When selecting steps (both completed and running), it shows "(no log content)" even for steps that should have logs. The step metadata (status, timing) loads correctly, but actual log text doesn't appear. The UI streams work for other execution types (pipeline logs view), suggesting the issue may be specific to how IACM workspace execution log keys are formatted or how the viewer interprets them. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> AI-Session-Id: 08f97a59-6f43-41fa-a3e7-ec643c5a75ed AI-Tool: claude-code AI-Model: unknown
The no_id: true flag prevented accepting workspace ID as a positional argument. Removed it so the command now works both ways: - harness execute workspace remote_execution (explicit ID) - harness execute workspace (reads from .harness/workspace.yaml) Updated examples and changed id_label to [workspace-id] to show it's optional. AI-Session-Id: 08f97a59-6f43-41fa-a3e7-ec643c5a75ed AI-Tool: claude-code AI-Model: unknown
…ce selection Since no_id: true prevents positional arguments, added --workspace flag as an alternative way to specify workspace ID. Now supports: - harness execute workspace (reads from .harness/workspace.yaml) - harness execute workspace --workspace remote_execution (explicit via flag) Updated handler to check --workspace flag before falling back to ctx.Id and then .harness/workspace.yaml file. AI-Session-Id: 08f97a59-6f43-41fa-a3e7-ec643c5a75ed AI-Tool: claude-code AI-Model: unknown
d311193 to
118a948
Compare
Collaborator
|
@rahulbalani-eng can you please fix the merge conflict changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Issue:
When the UI viewer launches, the left panel works correctly - it shows the step hierarchy, updates in real-time, and navigation works. However, the right panel does not display log content properly. When selecting steps (both completed and running), it shows "(no log content)" even for steps that should have logs. The step metadata (status, timing) loads correctly, but actual log text doesn't appear.
Screen.Recording.2026-07-01.at.11.12.53.PM.mov