Skip to content

fix: un-red main — dead import + app-bundle manifest re-pin (#504) - #505

Merged
aarontrowbridge merged 1 commit into
mainfrom
504-fix-main-red
Aug 22, 2026
Merged

fix: un-red main — dead import + app-bundle manifest re-pin (#504)#505
aarontrowbridge merged 1 commit into
mainfrom
504-fix-main-red

Conversation

@aarontrowbridge

@aarontrowbridge aarontrowbridge commented Aug 22, 2026

Copy link
Copy Markdown
Member

Closes #504.

Why: main is red in CI — fast typecheck (dead import left by the catalog removal) and app-bundle-gate drift (the devtools toggle fix #489 hand-copied into the overlay without re-pinning the manifest). Both failures predate the #306 merge; they block cutting the 0.2.4 release.

The fix (zero content change):

  • Removes the unused import from the extension entrypoint.
  • Re-pins manifest.json to a new fork release tag v1.18.10-amicode.15 — the .14 pin + cherry-pick of the fork's Pin the shipped Piccolo to the vetted 1.19 series #223 devtools fix (exactly the two hand-copied files), so a fresh extraction reproduces the current overlay byte-for-byte. The fork's later uncoordinated work (solver banner, workspace engine, settings permissions) is deliberately excluded — that sync belongs to its own PR.

Fork side (already pushed): release/v1.18.10-amicode.15 branch + tag on harmoniqs/opencode.

Verification: typecheck clean; drift gate PASS with the fork reachable (pins resolve, extraction matches manifest, overlay matches manifest); extension suite 1206 passed / 5 skipped / 100 files.

Summary by CodeRabbit

  • Chores
    • Updated application build metadata and file integrity information.
    • Refreshed fork version and extraction metadata.
    • Removed unused internal code without changing user-facing functionality.

Two failures inherited by the #306 merge commit, both predating it:

- fast/typecheck: the catalog removal left an unused import in the
  extension entrypoint — removed.
- app-bundle-gate: the devtools toggle fix (#489) was hand-copied into
  the committed overlay without re-pinning the manifest, so the overlay
  no longer matched what the pinned fork tag extracts. Fixed the
  designed way: fork release branch release/v1.18.10-amicode.15 =
  the .14 pin + cherry-pick of the fork's #223 devtools fix (the exact
  two hand-copied files), extractor re-run against it. Overlay content
  unchanged (manifest-only diff); the fork's later uncoordinated work
  (solver banner, workspace engine, settings permissions) is
  deliberately NOT pulled into this sync.

Closes #504.
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d771a12-8c8a-441c-9cf0-57600041ac29

📥 Commits

Reviewing files that changed from the base of the PR and between f0f5887 and cc2f7a4.

📒 Files selected for processing (2)
  • packages/app-bundle/manifest.json
  • packages/extension/src/extension.ts
💤 Files with no reviewable changes (1)
  • packages/extension/src/extension.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The change updates the app-bundle fork pin and related content hashes. It also removes an unused readTomlSafe import from the extension entrypoint.

Changes

Release pin and import cleanup

Layer / File(s) Summary
App-bundle manifest repin
packages/app-bundle/manifest.json
The manifest now records fork tag v1.18.10-amicode.15, its commit SHA, a new extraction timestamp, and refreshed hashes for two overlay files.
Extension import cleanup
packages/extension/src/extension.ts
The unused readTomlSafe import is removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to cc2f7

This change removes an unused import and re-pins the app-bundle manifest so fresh extraction matches the intended overlay; typecheck, drift validation, and the extension suite pass, so no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the dead import removal and manifest re-pin, which are the primary changes.
Linked Issues check ✅ Passed The changes address #504 by removing the unused import and re-pinning the manifest; the #489 fix is included through the referenced fork pin.
Out of Scope Changes check ✅ Passed The changes are limited to the requested import removal and manifest metadata re-pin, with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 504-fix-main-red

Comment @coderabbitai help to get the list of available commands.

@aarontrowbridge
aarontrowbridge merged commit 7fc29af into main Aug 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: un-red main — dead import + app-bundle manifest re-pin (release 0.2.4 blocker)

1 participant