fix: un-red main — dead import + app-bundle manifest re-pin (#504) - #505
Conversation
Two failures inherited by the #306 merge commit, both predating it: - fast/typecheck: the catalog removal left an unused import in the extension entrypoint — removed. - app-bundle-gate: the devtools toggle fix (#489) was hand-copied into the committed overlay without re-pinning the manifest, so the overlay no longer matched what the pinned fork tag extracts. Fixed the designed way: fork release branch release/v1.18.10-amicode.15 = the .14 pin + cherry-pick of the fork's #223 devtools fix (the exact two hand-copied files), extractor re-run against it. Overlay content unchanged (manifest-only diff); the fork's later uncoordinated work (solver banner, workspace engine, settings permissions) is deliberately NOT pulled into this sync. Closes #504.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe change updates the app-bundle fork pin and related content hashes. It also removes an unused ChangesRelease pin and import cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes an unused import and re-pins the app-bundle manifest so fresh extraction matches the intended overlay; typecheck, drift validation, and the extension suite pass, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Closes #504.
Why:
mainis red in CI —fasttypecheck (dead import left by the catalog removal) andapp-bundle-gatedrift (the devtools toggle fix #489 hand-copied into the overlay without re-pinning the manifest). Both failures predate the #306 merge; they block cutting the 0.2.4 release.The fix (zero content change):
manifest.jsonto a new fork release tagv1.18.10-amicode.15— the.14pin + cherry-pick of the fork's Pin the shipped Piccolo to the vetted 1.19 series #223 devtools fix (exactly the two hand-copied files), so a fresh extraction reproduces the current overlay byte-for-byte. The fork's later uncoordinated work (solver banner, workspace engine, settings permissions) is deliberately excluded — that sync belongs to its own PR.Fork side (already pushed):
release/v1.18.10-amicode.15branch + tag onharmoniqs/opencode.Verification: typecheck clean; drift gate PASS with the fork reachable (pins resolve, extraction matches manifest, overlay matches manifest); extension suite 1206 passed / 5 skipped / 100 files.
Summary by CodeRabbit