Skip to content

Add core domain override check documentation - #700

Open
ludeeus wants to merge 1 commit into
mainfrom
claude/core-domain-override-validator-hs911z
Open

Add core domain override check documentation#700
ludeeus wants to merge 1 commit into
mainfrom
claude/core-domain-override-validator-hs911z

Conversation

@ludeeus

@ludeeus ludeeus commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

This PR adds documentation for a new validation check that prevents custom integrations from overriding domains that belong to Home Assistant core integrations.

Changes

  • Added core_domain_override check to the checks table in action.md with documentation link and description
  • Added new "Check core domain override" section in include.md explaining:
    • The check applies only to integrations
    • It validates that custom integrations don't use the same domain as core Home Assistant integrations
    • References the "Who can submit?" section regarding acceptance criteria
  • Updated table formatting in action.md to accommodate the new check entry with proper column alignment

Details

The new check enforces a requirement that custom integrations cannot override core integration domains, which is part of the submission criteria for default inclusion in HACS. This documentation change makes users aware of this validation rule when using the HACS action.

For hacs/integration#5442

Add a `### Check core domain override` section to the include page and a row
to the ignorable checks table in the action page, for the new
`core_domain_override` action validator.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qc22QRVJF4ssjo7wPzBn2A

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents a new core_domain_override validation check in the HACS publishing docs, clarifying that custom integrations cannot use a domain belonging to a Home Assistant core integration and pointing users to the inclusion/submission criteria.

Changes:

  • Added a new “Check core domain override” section describing the validation rule and scope (integrations only).
  • Added core_domain_override to the action’s ignorable checks table, including a link to the new documentation section.
  • Adjusted the checks table formatting in action.md to accommodate the new entry cleanly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
source/docs/publish/include.md Adds a dedicated section explaining the core-domain-override validation and links back to submission criteria.
source/docs/publish/action.md Adds core_domain_override to the ignorable checks table and updates table formatting for readability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ludeeus
ludeeus marked this pull request as ready for review July 31, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants