Skip to content

adding athena intro - #301

Merged
24c02 merged 8 commits into
hackclub:mainfrom
lolasanchezz:main
Jul 31, 2026
Merged

adding athena intro#301
24c02 merged 8 commits into
hackclub:mainfrom
lolasanchezz:main

Conversation

@lolasanchezz

Copy link
Copy Markdown
Contributor

No description provided.

Comment on lines +18 to +21
def dialogue_flow
[
intro: [ template: "tutorial/athena/intro", next: nil ]
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dialogue_flow returns an Array here instead of a Hash – the outer [...] should be {...}, and same for the inner value brackets. as-is, template_for(:intro) will raise TypeError: no implicit conversion of Symbol into Integer when it tries to look up :intro on the Array. this will crash the onboarding flow for every Athena user on signup.

you can look at the other onboarding scenarios for how to do this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if they're being added as full members (they should) this will be looking for the :welcome template, so you should probably change the key!


def slack_onboarding_flow = :internal_tutorial
def slack_channels = chans(:athena_initiative, :welcome_to_athena, :athena_announcements)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def slack_user_type = :full_member

Comment thread app/views/slack/tutorial/athena/intro.slack_message.slocks Outdated
Comment on lines +18 to +21
def dialogue_flow
[
intro: [ template: "tutorial/athena/intro", next: nil ]
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if they're being added as full members (they should) this will be looking for the :welcome template, so you should probably change the key!

lolasanchezz and others added 2 commits July 31, 2026 12:43
Co-authored-by: 24c02 <163450896+24c02@users.noreply.github.com>
@24c02
24c02 merged commit d5e85aa into hackclub:main Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants