Skip to content

[RFC] Change Guard::RSpec to be a module and create Plugin which includes Compat::API - #397

Open
rymai wants to merge 1 commit into
masterfrom
guard-api
Open

[RFC] Change Guard::RSpec to be a module and create Plugin which includes Compat::API#397
rymai wants to merge 1 commit into
masterfrom
guard-api

Conversation

@rymai

@rymai rymai commented Jun 17, 2017

Copy link
Copy Markdown
Member

No description provided.

…ompat::API

Signed-off-by: Rémy Coutable <remy@rymai.me>
@rymai rymai changed the title Change Guard::RSpec to be a module and create Plugin which includes Compat::API [RFC] Change Guard::RSpec to be a module and create Plugin which includes Compat::API Jun 17, 2017
require "guard/rspec/plugin"

RSpec.describe Guard::RSpec do
RSpec.describe Guard::RSpec::Plugin do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [72/25]

Comment thread lib/guard/rspec/plugin.rb
@@ -0,0 +1,40 @@
module Guard

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

@coveralls

coveralls commented Jun 17, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-56.01%) to 42.225% when pulling 2744758 on guard-api into 1cf25c7 on master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-56.01%) to 42.225% when pulling 2744758 on guard-api into 1cf25c7 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants