docs: correct overstated "secret leak" claim in architecture review - #113
Open
groupthinking wants to merge 1 commit into
Open
docs: correct overstated "secret leak" claim in architecture review#113groupthinking wants to merge 1 commit into
groupthinking wants to merge 1 commit into
Conversation
The committed .env held development placeholders (DWAVE_API_TOKEN=development-mode, dev-* keys), not live credentials, so the original 'live secret leak' framing and the 'rotate the committed secrets' recommendation were overstated. Reframe as what it is: a tracked .env anti-pattern (untracked in #112). No rotation required. https://claude.ai/code/session_01AGrYSaaxGvpbp4Wzy3o2mi
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ARCHITECTURE_REVIEW.md to clarify that the committed .env file contains development placeholders rather than live credentials, meaning secret rotation is not required. It still emphasizes that tracking .env is an anti-pattern and notes that this has been addressed in #112. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
groupthinking
marked this pull request as ready for review
June 4, 2026 06:30
groupthinking
enabled auto-merge (squash)
June 4, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct overstated "secret leak" claim
The merged red-team review (#110) described the committed
.envas a "live secret leak in version control" and recommended rotating the committed secrets. When #112 exposed the actual values, they turned out to be development placeholders, not real credentials:DWAVE_API_TOKENdevelopment-modeJWT_SECRET_KEYdev-jwt-secret-key-minimum-32-characters-longAPI_SECRET_KEYdev-api-secret-key-minimum-32-characters-longENCRYPTION_KEYdev-encryption-key-for-local-development-onlyThis PR softens the four places that overstated it, reframing the finding as what it actually is: a tracked
.envanti-pattern (a file that shouldn't be tracked regardless of current contents, since it invites a future real leak) — already remediated by untracking in #112. No rotation was or is required.Changes (all in
ARCHITECTURE_REVIEW.md).env(dev placeholders)"..env; no rotation required".A document whose value rests on every claim being verifiable shouldn't carry a severity claim we've since disproven. Every other finding in the review stands unchanged.
https://claude.ai/code/session_01AGrYSaaxGvpbp4Wzy3o2mi
Generated by Claude Code