feat(velocity): bundle permissions REST client - #198
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f05ff13505
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -n "$PLUGINS" ]; then \ | ||
| PLUGINS="$PLUGINS" GITHUB_TOKEN="$github_token" /app/download-plugins.sh; \ | ||
| fi; \ | ||
| /app/verify-permissions-rest-jar.sh /app/plugins/plugin-permissions-velocity.jar; \ |
There was a problem hiding this comment.
Skip verification when permissions is not requested
When a caller uses the documented PLUGINS build argument to omit plugin-permissions-velocity (including setting it to an empty string), the download step never creates this JAR, but this unconditional verifier invocation exits with missing_rest_client, causing an otherwise valid customized image build to fail. Guard verification on the artifact being requested/present, or download the mandatory permissions plugin independently of the customizable list.
Useful? React with 👍 / 👎.
Pull Request
Description
Moves the Velocity base image to the REST-only permissions plugin.
plugin-permissions-velocityto0.7.0.PERMISSIONS_SERVICE_URLandPERMISSIONS_TOKEN_FILEruntime contract.This image must be released before the platform bundle switches permissions consumers away from gRPC.
Type of Change
Related Issues
Testing
plugin-permissions-velocityJAR contains the REST clientChecklist