Skip to content

If Dirichlet DoFs, cell_to_DOFs is lazy array - #214

Merged
JordiManyer merged 1 commit into
gridap:agfemfrom
ericneiva:bugfix-agfem
Jul 29, 2026
Merged

If Dirichlet DoFs, cell_to_DOFs is lazy array#214
JordiManyer merged 1 commit into
gridap:agfemfrom
ericneiva:bugfix-agfem

Conversation

@ericneiva

Copy link
Copy Markdown
Member

Hello @JordiManyer,

This is a minor fix that I needed to apply to the agfem branch when I tested problems with Dirichlet BCs.

Lmk if you have any suggestions for improvement. Otherwise, thanks a lot for accepting the PR.

Cheers,
Eric

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.89%. Comparing base (e152a90) to head (fb450a7).

Additional details and impacted files
@@           Coverage Diff           @@
##            agfem     #214   +/-   ##
=======================================
  Coverage   76.89%   76.89%           
=======================================
  Files          17       17           
  Lines        4645     4645           
=======================================
  Hits         3572     3572           
  Misses       1073     1073           
Flag Coverage Δ
mpi-adaptivity 41.20% <ø> (ø)
mpi-fespaces 36.14% <ø> (ø)
mpi-geometry 20.76% <ø> (ø)
mpi-misc 45.60% <ø> (ø)
mpi-physics 32.18% <ø> (ø)
mpi-transient 22.27% <ø> (ø)
seq-adaptivity 35.64% <ø> (ø)
seq-fespaces 38.03% <ø> (ø)
seq-geometry 20.80% <ø> (ø)
seq-misc 31.71% <ø> (ø)
seq-physics 32.07% <ø> (ø)
seq-transient 21.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JordiManyer

JordiManyer commented Jul 29, 2026

Copy link
Copy Markdown
Member

Hi @ericneiva . If I do not used anywhere else the fact that those are tables, I guess its good to go. Per your comment, I assume everything works verbatim.

@JordiManyer
JordiManyer merged commit 9ed4122 into gridap:agfem Jul 29, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants