fix(models): harden preparation downloads - #36
Merged
Conversation
tulayha
marked this pull request as ready for review
July 31, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_download_faileddetails consistently through durable jobs, CLI JSON, HTTP, and MCPRoot cause
Model preparation reported individual Hugging Face file totals as if they were the full model total. An interrupted or incomplete snapshot could then collapse into the generic model-unavailable path, producing circular remediation and hiding whether cached data could resume. Download failures also lacked a transport-stable error contract.
Impact
Cached pinned models are validated before any network work. Transient Hugging Face failures preserve and resume cache data, terminal failures are not retried, and unexpected programming exceptions remain visible. CLI, API, and MCP consumers receive the same structured job progress and error fields. Existing provider initialization and warm-up behavior remains unchanged.
Validation
python -m unittest discover -s tests -q— 479 passed, 3 skippedruff check src testsgit diff --checkvidxp doctoragainst the preserved shared cache passed for actor, dialogue, scene, storage, FFmpeg, and all pinned models