Develop - #91
Open
Dominik-Matysiak-gravity wants to merge 2 commits into
Open
Conversation
…ion-0 Documents without partition key field are silently filtered out
There was a problem hiding this comment.
The fix correctly addresses the silent data loss issue by routing documents without partition keys to partition 0 instead of filtering them out. The cascading conditional expression provides a clean fallback mechanism, and the comprehensive test coverage validates the behavior across multiple scenarios including INSERT, UPDATE, and DELETE operations with custom keys.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where change stream events without the partition key matched no partition and were silently dropped. Replaced the three $or branches with a cascading expression that picks the first available key source and falls back to DEFAULT_PARTITION = 0, leaving routing unchanged when the key is present.