Skip to content

test: expand GitHub datasource E2E coverage - #797

Open
akkikumar72 wants to merge 2 commits into
mainfrom
chore/github-e2e-coverage-205
Open

test: expand GitHub datasource E2E coverage#797
akkikumar72 wants to merge 2 commits into
mainfrom
chore/github-e2e-coverage-205

Conversation

@akkikumar72

Copy link
Copy Markdown
Contributor
  • Add variable-query editor coverage that verifies the serialized Releases request and rendered preview values
  • Add representative Branches coverage for filter serialization and rendered query results
  • Keep the scope bounded to deterministic mocks instead of duplicating all query modes
  • Checks: Playwright 5/5, Jest 21/21, typecheck, lint, production build, Go tests, and Prettier on Node 24.19.0

Closes #205

Copilot AI lite review requested due to automatic review settings August 11, 2026 11:44
@akkikumar72
akkikumar72 requested a review from a team as a code owner August 11, 2026 11:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands end-to-end coverage for the GitHub datasource query/variable editors using deterministic mocked query responses, addressing the gap noted in #205.

Changes:

  • Adds a new E2E test for the Variable Query Editor to validate Releases query serialization (metricFindQuery) and rendered preview values.
  • Extends Query Editor E2E coverage with a Branches test validating filter serialization and rendered table output.
  • Introduces additional mock responses to support the new E2E scenarios (variable refId and branches frame).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/VariableQueryEditor.spec.ts New E2E test covering variable query (Releases) request serialization and preview rendering.
tests/QueryEditor.spec.ts Adds E2E coverage for Branches query filter serialization and table rendering.
tests/mocks/github-response.ts Adds deterministic mock responses for variable queries (metricFindQuery) and branches results.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[github] Improve e2e tests

2 participants