feat: add optional file URL field to packed file responses#2147
Open
Santirv17 wants to merge 1 commit into
Open
feat: add optional file URL field to packed file responses#2147Santirv17 wants to merge 1 commit into
Santirv17 wants to merge 1 commit into
Conversation
|
spaenleh
reviewed
Jul 8, 2026
spaenleh
left a comment
spaenleh
left a comment
Member
There was a problem hiding this comment.
Overall changes look good, but I would take a second look at my comment just to ensure that we do not end up with a potential crash on our hand.
| thumbnails, | ||
| ); | ||
| return filteredChildren.map((children) => this.transformItemByType(children)); | ||
| return Promise.all(filteredChildren.map((child) => this.transformItemByType(child))); |
Member
There was a problem hiding this comment.
I am always wary of using Promise.all because it will reject at the first promise that rejects, continuing the program flow. This means that if a second promise rejects later, it can crash the server since the execution moved on. Instead I would rather use Promise.allSettled which ensures that all promises either resolve or reject to continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add file URLs to packed file item responses so clients can open file children without an additional URL request.
extra.file.urlas optional response data/childrenreturns the URL for file children while non-file children remain unchangedclose #2082