Support aliased type designators - #6
Closed
gouttegd wants to merge 1 commit into
Closed
Conversation
This commit lays the groundwork for allowing resolution of type designators using a custom set of aliases. It introduces a new ITypeDesignatorResolver interface, and breaks down the existing TypeDesignatorResolver class into two parts: * a new DefaultTypeDesignatorResolver class, which implements the core logic to resolve designators using only informations from class annotations; * the TypeDesignatorResolver class (what is left of it), which relies on the new DefaultTypeDesignatorResolver to resolve single-valued designators and builds on top of that to deal with multi-valued designators (the idea is that the logic to deal with multi-valued designators should always be the same, regardless of which internal resolver is used to resolve a single designator). Then, it adds a new AliasTypeDesignatorResolver class, which uses a custom map (to be set by client code) of aliases to perform type designator resolution. The system is not fully designed -- not sure yet about the best way to plug the alias-based resolver into the ConverterContext object.
Owner
Author
|
Done in the main branch in a slightly different way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for allowing resolution of type designators using a custom set of aliases, instead of only the name and/or the URI of a class.
It introduces a new ITypeDesignatorResolver interface, and breaks down the existing TypeDesignatorResolver class into two parts:
Then, it adds a new AliasTypeDesignatorResolver class, which uses a custom map (to be set by client code) of aliases to perform type designator resolution.
The system is not fully designed -- not sure yet about the best way to plug the alias-based resolver into the ConverterContext object (hence this PR, until the design is finalised).