refactor(core): extract metric package - #25
Closed
zhangzhenghao wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 61.38% 61.39%
=======================================
Files 155 156 +1
Lines 40415 40415
=======================================
+ Hits 24810 24814 +4
+ Misses 12367 12365 -2
+ Partials 3238 3236 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Closing this PR because the verified commit will be pushed directly to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/core/metriccore.Metricand metric constants through aliases while establishing the lower-level dependency boundaryThis is the first small step of restructuring
internal/coreafter Alibaba zvec’score/metric,core/quantizer, andcore/algorithmresponsibility split. It intentionally makes no scoring, ordering, persistence, or public API behavior changes.Verification
go test ./...go test -race ./...go vet ./...git diff --checkgo test ./internal/core/metric -coverprofile=/tmp/xvec-core-metric.cover(100% statement coverage)