perf(query): allow writes during snapshot searches - #23
Open
zhangzhenghao wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 61.44% 61.54% +0.09%
==========================================
Files 150 150
Lines 40358 40462 +104
==========================================
+ Hits 24799 24901 +102
- Misses 12344 12346 +2
Partials 3215 3215 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query,MultiQuery, andGroupByQueryrelease the collection read lock before long-running search workCloseandDestroywait for active query leases and retry/report delayed runtime close errorsThis follows Alibaba zvec's separation between short collection-handle locking and stable segment ownership, implemented with pure-Go lifecycle management.
Tests
go test ./... -count=1 -timeout=20mgo test -race ./... -count=1 -timeout=30mgo vet ./...-count=20/-count=50git diff --checkScope
This change addresses query/write lock contention and safe runtime reclamation. It does not change the on-disk format, writer serialization, or ANN algorithms.