fix(types, tunings): resolve optional IPython mypy type errors (#1288)#2773
Open
giterinhub wants to merge 1 commit into
Open
fix(types, tunings): resolve optional IPython mypy type errors (#1288)#2773giterinhub wants to merge 1 commit into
giterinhub wants to merge 1 commit into
Conversation
5 tasks
…ogleapis#1761) Related to googleapis#1761 Addresses part of googleapis#1761 - Add # type: ignore annotations for optional IPython module assignments and untyped calls in types.py and tunings.py - Resolves 9 static analysis mypy type checking failures when ipython is uninstalled or untyped
giterinhub
force-pushed
the
fix/ipython-mypy-annotations
branch
from
July 24, 2026 08:23
ac83344 to
4a6776b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1288
Addresses part of #1761
Summary & Context
This PR resolves 9 pre-existing
mypytype checking errors ingoogle/genai/types.pyandgoogle/genai/tunings.pyrelated to optionalIPythonimports and untyped calls.Changes Made
# type: ignore[assignment]and# type: ignore[no-untyped-call]annotations for optionalIPython_displayhandling ingoogle/genai/types.py.# type: ignore[attr-defined]and# type: ignore[no-untyped-call]annotations for optionalIPythonnotebook helper functions ingoogle/genai/tunings.py.Verification
mypy google/genai/-> Success: no issues found in 35 source files.