feat: add AlloyDB time-series forecasting methods to AlloyDBEngine - #630
Open
madamsetty-pavan wants to merge 6 commits into
Open
feat: add AlloyDB time-series forecasting methods to AlloyDBEngine#630madamsetty-pavan wants to merge 6 commits into
madamsetty-pavan wants to merge 6 commits into
Conversation
- Add aforecast and forecast methods on AlloyDBEngine - Add parameter validation for forecasting inputs - Add dynamic SQL builder for google_ml.forecast - Add unit tests covering validation errors and SQL generation
product-auto-label
Bot
added
the
api: alloydb
twishabansal
added
the
priority: p2
zhou0ricky
reviewed
Sep 3, 2026
| if not model_id or not isinstance(model_id, str) or not model_id.strip(): | ||
| raise ValueError("model_id must be a non-empty string.") | ||
| if ( | ||
| not source_table |
There was a problem hiding this comment.
From what I read, source_table and source_query are mutually exclusive. Here if source_table is empty an error is thrown. Is this intentional?
zhou0ricky
reviewed
Sep 3, 2026
| ): | ||
| raise RuntimeError( | ||
| "AlloyDB AI google_ml extension is not installed or enabled. " | ||
| "Please execute 'CREATE EXTENSION IF NOT EXISTS google_ml CASCADE;' on your database." |
There was a problem hiding this comment.
This should be google_ml_integration
zhou0ricky
approved these changes
Sep 3, 2026
zhou0ricky
left a comment
zhou0ricky
left a comment
There was a problem hiding this comment.
Left a few comments, looks good otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add AlloyDB time-series forecasting methods to AlloyDBEngine