tests: remove protobuf cpp from tests which is no longer used as of Protobuf 4.x#17742
Draft
parthea wants to merge 3 commits into
Draft
tests: remove protobuf cpp from tests which is no longer used as of Protobuf 4.x#17742parthea wants to merge 3 commits into
parthea wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test configuration for google-cloud-bigtable and google-cloud-spanner by adding support for Python 3.15 and removing the deprecated 'cpp' protobuf implementation from all test sessions. Additionally, it includes a temporary skip for Python 3.15 unit tests pending the availability of google-crc32c wheels. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
google-cloud-spannerandgoogle-cloud-bigtableonly support Protobuf 6.x+ . The tests for protobuf implementation backendcppare no longer needed .google-cloud-python/packages/google-cloud-spanner/setup.py
Line 54 in 2c3c213
google-cloud-python/packages/google-cloud-bigtable/setup.py
Line 52 in 2c3c213
This PR also skips Python 3.15 testing for
google-cloud-bigtablebecause it depends on 3.15 wheels fromgoogle-crc32c. The follow up work is tracked in #17741