[DO not submit] [testing] takeover issues test in CI#13780
Conversation
There was a problem hiding this comment.
Code Review
This pull request enables running the ITAppendableUploadTest against the production backend (Backend.PROD) in addition to the test bench. It also updates BackendResources.java to hardcode the region and zone values to 'us-central1' and 'us-central1-c'. The reviewer points out that hardcoding these values limits the portability of the integration tests and suggests dynamically resolving them from the runner context instead.
| .setLocation("us-central1") | ||
| .setCustomPlacementConfig( | ||
| CustomPlacementConfig.newBuilder() | ||
| .setDataLocations(ImmutableList.of(zone.get().get().getZone())) | ||
| .setDataLocations(ImmutableList.of("us-central1-c")) |
There was a problem hiding this comment.
Hardcoding the region (us-central1) and zone (us-central1-c) limits the portability of the integration tests. It is highly recommended to dynamically resolve these values using the configured zone/region from the runner context to ensure tests can run seamlessly across different environments or projects.
| .setLocation("us-central1") | |
| .setCustomPlacementConfig( | |
| CustomPlacementConfig.newBuilder() | |
| .setDataLocations(ImmutableList.of(zone.get().get().getZone())) | |
| .setDataLocations(ImmutableList.of("us-central1-c")) | |
| .setLocation(zone.get().get().getRegion()) | |
| .setCustomPlacementConfig( | |
| CustomPlacementConfig.newBuilder() | |
| .setDataLocations(ImmutableList.of(zone.get().get().getZone())) |
No description provided.