Skip to content

[DO not submit] [testing] takeover issues test in CI#13780

Open
Dhriti07 wants to merge 1 commit into
mainfrom
prove-takeover-bugs
Open

[DO not submit] [testing] takeover issues test in CI#13780
Dhriti07 wants to merge 1 commit into
mainfrom
prove-takeover-bugs

Conversation

@Dhriti07

Copy link
Copy Markdown
Contributor

No description provided.

@Dhriti07 Dhriti07 requested review from a team as code owners July 15, 2026 19:35

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables running the ITAppendableUploadTest against the production backend (Backend.PROD) in addition to the test bench. It also updates BackendResources.java to hardcode the region and zone values to 'us-central1' and 'us-central1-c'. The reviewer points out that hardcoding these values limits the portability of the integration tests and suggests dynamically resolving them from the runner context instead.

Comment on lines +262 to +265
.setLocation("us-central1")
.setCustomPlacementConfig(
CustomPlacementConfig.newBuilder()
.setDataLocations(ImmutableList.of(zone.get().get().getZone()))
.setDataLocations(ImmutableList.of("us-central1-c"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the region (us-central1) and zone (us-central1-c) limits the portability of the integration tests. It is highly recommended to dynamically resolve these values using the configured zone/region from the runner context to ensure tests can run seamlessly across different environments or projects.

Suggested change
.setLocation("us-central1")
.setCustomPlacementConfig(
CustomPlacementConfig.newBuilder()
.setDataLocations(ImmutableList.of(zone.get().get().getZone()))
.setDataLocations(ImmutableList.of("us-central1-c"))
.setLocation(zone.get().get().getRegion())
.setCustomPlacementConfig(
CustomPlacementConfig.newBuilder()
.setDataLocations(ImmutableList.of(zone.get().get().getZone()))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant