Skip to content

Allow ProfilerController to consume data in the kCollectData state. #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow ProfilerController to consume data in the kCollectData state. #3613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsl/profiler/lib/profiler_collection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ absl::StatusOr<ConsumeResult> ProfilerCollection::Consume() {
data_vector.push_back(std::move(result->data));
total_estimated_size_bytes += result->estimated_size_bytes;
} else if (absl::IsUnimplemented(result.status())) {
LOG(WARNING) << "Profiler consume not implemented: " << result.status();
VLOG(1) << "Profiler consume not implemented: " << result.status();
data_vector.push_back(std::any());
} else {
LOG(ERROR) << "Profiler consume failed: " << result.status();
Expand Down
3 changes: 2 additions & 1 deletion tsl/profiler/lib/profiler_controller.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ absl::Status ProfilerController::CollectData(
}

absl::StatusOr<ConsumeResult> ProfilerController::Consume() {
if (state_ != ProfilerState::kStart && state_ != ProfilerState::kStop) {
if (state_ != ProfilerState::kStart && state_ != ProfilerState::kStop &&
state_ != ProfilerState::kCollectData) {
return absl::AbortedError("Consume called in the wrong order.");
}
if (!status_.ok()) {
Expand Down
Loading