Eliminate double counting of treatment subrelease stats in HugePageFiller. - #704
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Eliminate double counting of treatment subrelease stats in HugePageFiller.#704copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ller. In HugePageFiller::HandleReleaseFree and HandleUnbackedHugePage, released and unmapped lengths were directly added to subrelease_stats_.total_pages_subreleased while also accumulating into unmapping_unaccounted_. ReleasePages drains unmapping_unaccounted_ into subrelease_stats_.num_pages_subreleased, and UpdateFillerStatsTracker rolls num_pages_subreleased into total_pages_subreleased on allocation or epoch boundaries, double counting all treatment-subreleased pages in cumulative statistics. PiperOrigin-RevId: 978638844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate double counting of treatment subrelease stats in HugePageFiller.
In HugePageFiller::HandleReleaseFree and HandleUnbackedHugePage, released and
unmapped lengths were directly added to subrelease_stats_.total_pages_subreleased
while also accumulating into unmapping_unaccounted_. ReleasePages drains
unmapping_unaccounted_ into subrelease_stats_.num_pages_subreleased, and
UpdateFillerStatsTracker rolls num_pages_subreleased into
total_pages_subreleased on allocation or epoch boundaries, double counting all
treatment-subreleased pages in cumulative statistics.