Guard slabs_end hugepage_status marking with IsAlignedTo in ReleaseSlabMetadataForDrainedCpus. - #695
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Guard slabs_end hugepage_status marking with IsAlignedTo in ReleaseSlabMetadataForDrainedCpus.#695copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…abMetadataForDrainedCpus. When slabs_end is hugepage-aligned, `address_to_hugepage_number(slabs_end) - base_hugepage_nr` indexes the hugepage immediately following the allocated slabs, causing an out-of-bounds array write and erroneously marking an untouched hugepage as kCannotFree. Guard the marking with `!IsAlignedTo(slabs_end, kHugePageSize)`. PiperOrigin-RevId: 978002656
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard slabs_end hugepage_status marking with IsAlignedTo in ReleaseSlabMetadataForDrainedCpus.
When slabs_end is hugepage-aligned,
address_to_hugepage_number(slabs_end) - base_hugepage_nrindexes the hugepageimmediately following the allocated slabs, causing an out-of-bounds array write
and erroneously marking an untouched hugepage as kCannotFree. Guard the marking
with
!IsAlignedTo(slabs_end, kHugePageSize).