Make SizeMap calculation faster for small sizes - #645
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Make SizeMap calculation faster for small sizes#645copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Index sizes <= 1024 directly by size, this increases the lookup array size by 896 bytes, but removes 2 instructions from the fast path: 7e5449: 48 8d 47 07 leaq 0x7(%rdi), %rax 7e544d: 48 c1 e8 03 shrq $0x3, %rax PiperOrigin-RevId: 975784186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SizeMap calculation faster for small sizes
Index sizes <= 1024 directly by size, this increases the lookup array size by 896 bytes, but removes 2 instructions from the fast path:
7e5449: 48 8d 47 07 leaq 0x7(%rdi), %rax
7e544d: 48 c1 e8 03 shrq $0x3, %rax