Fix/56 bq delete protection - #226
Merged
Merged
Conversation
Collaborator
|
What do you think about parameterizing it so that it's an easy toggle rather than having to flip a few switches? |
aghassemlouei
enabled auto-merge (rebase)
September 9, 2026 13:35
…nor formatting cleanup across stages
…atting in resmsn stage
…for networking stage
aghassemlouei
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a configurable force_destroy parameter, enhances resource protection and deletion safety, ensures configuration audit compliance, and optimizes the code layout across all FAST Assured Workloads stages (fast/stages-aw).
Introduced a new configurable variable force_destroy (defaulting to false) to replace hardcoded values and allow users to toggle force deletion of managed GCS buckets across the workspace stages:
* Added Variable Definition (force_destroy default false):
Variable Alphabetization & Clean Code Refactoring
NGFW Bootstrap GCS Bucket Versioning
Ensured GCS object versioning (versioning = true) on the ngfw-bootstrap-bucket in fast/stages-aw/2-networking-b-il5-ngfw/ngfw.tf is paired with safe deletion parameters
Fixes #56 (GitHub issue id)
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
terraform fmt: Executed on all modified stage files to ensure clean formatting with zero diffs.git status: Confirmed exactly 6 files modified matching our intentional changes.