allocations.ql: match kmalloc calls by attribute, not name#408
Open
artmetla wants to merge 1 commit into
Open
Conversation
Kernel's alloc-profiling rework renamed kmalloc/kzalloc/kvmalloc to *_noprof, breaking the name-based match. Identify calls via the __alloc_size attribute + gfp_t parameter instead, so the same query works on both old-name (e.g. 6.1) and *_noprof (6.12+) kernels, and survives future renames the same way. Also: - Drop the isAffectedByMacro() filter on the size arg. Every *_noprof call is now macro-wrapped (alloc_hooks()), so this filter would exclude every row; it also excluded struct_size()/array_size() allocations even before the rework, which is the flexible-array pattern this query is meant to find. - Fix getStruct() producing duplicate rows when its two resolution branches (sizeof-based and pointer-cast fallback) both matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel's alloc-profiling rework renamed kmalloc/kzalloc/kvmalloc to *_noprof, breaking the name-based match. Identify calls via the __alloc_size attribute + gfp_t parameter instead, so the same query works on both old-name (e.g. 6.1) and *_noprof (6.12+) kernels, and survives future renames the same way.
Also: