feat(soar): enable trust_env in HttpClient session for corporate proxies (#198) - #311
Open
dandye wants to merge 1 commit into
Open
feat(soar): enable trust_env in HttpClient session for corporate proxies (#198)#311dandye wants to merge 1 commit into
dandye wants to merge 1 commit into
Conversation
…ies (#198) - Sets trust_env=True on aiohttp.ClientSession in HttpClient._get_session to honor standard HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables - Adds unit tests in test_http_client.py verifying session proxy environment trust - Documents corporate proxy configuration and SSL CA bundles in usage_guide.md and secops-soar README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #198.
This PR adds corporate proxy support for the Google SecOps SOAR MCP server and documents corporate proxy configuration across the repository.
Changes
HttpClient._get_session(), initializeaiohttp.ClientSession(trust_env=True)so it respects standard environment variables (HTTP_PROXY,HTTPS_PROXY,NO_PROXY). This brings SOAR into parity with GTI (feat: gti: Enable trust_env in vt.Client initialization for proxies. #273) and SecOps SIEM (httpx).server/secops-soar/tests/unit/test_http_client.pyto verify thatHttpClientpassestrust_env=Trueand initializes sessions withtrust_env=True.docs/usage_guide.mdandserver/secops-soar/README.mddetailing environment variables, MCP client settings, and custom CA bundles (SSL_CERT_FILE).Testing
server/secops-soar:uv run --extra test pytest tests/unit/(all 7 passed)server/gti:uv run --extra test pytest tests/test_tools.py(all 49 passed)