builtin: add :ne, inequality over two evaluated constants - #92
Open
brian-slashguard wants to merge 1 commit into
Open
builtin: add :ne, inequality over two evaluated constants#92brian-slashguard wants to merge 1 commit into
brian-slashguard wants to merge 1 commit into
Conversation
Mangle has :lt/:le/:gt/:ge but no not-equals, so every inequality must be written as negation over a domain the program derives first. That is a recurring authoring and review cost for a common construct. Adds :ne at the four registration points :lt uses — symbol, arg modes, decision case, and relation type. The relation type is the non-obvious one: without it the predicate parses and reaches evaluation, then fails type inference with 'cannot find assignment that works for premise :ne(A,B)', which reads like a broken implementation. Verified: differs(A,B) :- colour(A), colour(B), :ne(A,B) over three colours yields the six ordered pairs of distinct values.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mangle has
:lt/:le/:gt/:gebut no not-equals, so every inequality must be written as negation over a domain the program derives first.This adds
:neat the same four registration points:ltuses: symbol declaration, arg modes, the decision case, and the relation type.The relation type is the non-obvious one — without it the predicate parses and reaches evaluation, then fails type inference with
cannot find assignment that works for premise :ne(A,B), which reads like a broken implementation rather than a missing registration.Verified:
differs(A,B) :- colour(A), colour(B), :ne(A,B).over three colours yields the six ordered pairs of distinct values.go build ./...is clean.Happy to adjust naming or the type bound if you'd prefer something narrower than
AnyBound.