Rename {Move,Copy}CtorStyle and has_{move,copy}_ctor_and_assignment_operator - #1887
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_971439635
branch
2 times, most recently
from
August 26, 2026 20:57
0f8bb8f to
46a1b99
Compare
…perator
These names are extremely misleading because they suggest information on how the corresponding C++ type will behave, rather than _how we would make the C++ type behave is we generated it purely from the information on the Rust type_.
In particular, it falls apart for Rust types that have an existing C++ type that already exists. In cases where the Rust type came from a C++ type via rs_bindings_from_cc, this could literally return the wrong answer ("your type, which literally corresponds to a movable C++ type, won't be movable in C++ because I looked at its shape in Rust and it doesn't implement Default mhm.")
By itself, this doesn't fix anything. But it will make followup bugfixing changes more intuitive.
PiperOrigin-RevId: 971497455
copybara-service
Bot
force-pushed
the
test_971439635
branch
from
August 26, 2026 21:24
46a1b99 to
a6c6112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename {Move,Copy}CtorStyle and has_{move,copy}_ctor_and_assignment_operator
These names are extremely misleading because they suggest information on how the corresponding C++ type will behave, rather than how we would make the C++ type behave is we generated it purely from the information on the Rust type.
In particular, it falls apart for Rust types that have an existing C++ type that already exists. In cases where the Rust type came from a C++ type via rs_bindings_from_cc, this could literally return the wrong answer ("your type, which literally corresponds to a movable C++ type, won't be movable in C++ because I looked at its shape in Rust and it doesn't implement Default mhm.")
By itself, this doesn't fix anything. But it will make followup bugfixing changes more intuitive.