Refactoring upcast. - #1877
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
This CL splits the `Inherits` trait into two traits, `Inherits` (with safe functions) and `InheritsVirtual` (with unsafe functions). Crubit will generate `InheritsVirtual` trait for classes which are inheriting virtually from Base class (needs static_cast for converting to Base class). PiperOrigin-RevId: 960081566
copybara-service
Bot
force-pushed
the
test_960081566
branch
from
August 26, 2026 06:57
68dbb01 to
c7e17d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring upcast.
This CL splits the
Inheritstrait into two traits,Inherits(with safe functions) andInheritsVirtual(with unsafe functions).Crubit will generate
InheritsVirtualtrait for classes which are inheriting virtually from Base class (needs static_cast for converting to Base class).