Support clang::VisibilityAttr on user C++ declarations. - #1741
Open
copybara-service[bot] wants to merge 1 commit into
Open
Support clang::VisibilityAttr on user C++ declarations.#1741copybara-service[bot] wants to merge 1 commit into
clang::VisibilityAttr on user C++ declarations.#1741copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_962643447
branch
from
August 11, 2026 09:08
0ea9c7a to
1ad21ea
Compare
copybara-service
Bot
force-pushed
the
test_962643447
branch
2 times, most recently
from
August 24, 2026 10:59
36a4023 to
d521be6
Compare
copybara-service
Bot
changed the title
rs_bindings_from_cc only recognized clang::VisibilityAttr for records in the std:: namespace, and rejected all other user declarations with "Attributes are not supported: visibility", causing valid exported C++ APIs, including those annotated with ???_EXPORT or symbol visibility macros to be silently omitted as UnsupportedItem.clang::VisibilityAttr on user C++ declarations.
Previously, `rs_bindings_from_cc` only recognized `clang::VisibilityAttr` for records in the std:: namespace, and rejected all other user declarations with "Attributes are not supported: visibility", causing valid exported C++ APIs, including those annotated with `???_EXPORT` or symbol visibility macros to be silently omitted as `UnsupportedItem`. PiperOrigin-RevId: 962643447
copybara-service
Bot
force-pushed
the
test_962643447
branch
from
August 26, 2026 00:21
d521be6 to
28b8917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
clang::VisibilityAttron user C++ declarations.Previously,
rs_bindings_from_cconly recognizedclang::VisibilityAttrfor records in the std:: namespace, and rejected all other user declarations with "Attributes are not supported: visibility", causing valid exported C++ APIs, including those annotated with???_EXPORTor symbol visibility macros to be silently omitted asUnsupportedItem.