fix(vsock): drain host data before reporting EOF#472
Merged
Conversation
Keep a host-initiated UDS connection alive after the peer closes until its buffered data has been delivered to guest RX buffers. Report the close with a VSOCK RST only after the data is drained, and resume pending reads when RX descriptors become available. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Coverage Report for CI Build 30075428678Coverage increased (+0.4%) to 27.784%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep a host-initiated UDS connection alive after the peer closes until its buffered data has been delivered to guest RX buffers. Report the close with a VSOCK RST only after the data is drained, and resume pending reads when RX descriptors become available.