feat: add browser companion protocol - #219
Merged
Merged
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rewritten Grimoire Companion could not safely use the current daemon: extension-origin writes were rejected, general taxonomy routes were outside a dedicated authenticated boundary, and there was no stable capability handshake. This adds a versioned browser-integration protocol with authenticated capability and taxonomy endpoints, permits packaged Chrome and Firefox origins only on the three required routes, and explicitly rejects extension-origin access to unrelated daemon reads and writes.
The companion can now negotiate protocol v1, load categories and tags through its bearer token, and submit a normal
/capturerequest without broadening Grimoire beyond loopback. The generated API contract and browser-capture guidance are updated.Validation:
bun test daemon/src/test/integration/browser-integration.test.ts daemon/src/test/integration/capture.test.ts daemon/src/test/integration/integration-token-auth.test.ts daemon/src/test/integration/security-hardening.test.ts(28 passed, 129 assertions)npm run lint(no errors; 8 existing Fast Refresh warnings)npm run type-checknpm run docs:api:check